Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added records for undocumented changed. #780

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Nov 27, 2023

No description provided.

@mgcam mgcam requested a review from jmtcsngr November 27, 2023 09:55
@mgcam mgcam force-pushed the update_changes_file branch from 8206a15 to ff1a0f0 Compare November 27, 2023 12:03
Changes Outdated
since HiSeq instruments are no longer used.
have different references;
- ensured 'required_insert_size' method works correctly for objects that
are initialised wiht the 'rpt_list' attribute, ie have the 'position'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are initialised wiht the 'rpt_list' attribute, ie have the 'position'
are initialised with the 'rpt_list' attribute, ie have the 'position'

@mgcam mgcam force-pushed the update_changes_file branch from ff1a0f0 to c0ca4eb Compare November 27, 2023 13:43
@jmtcsngr jmtcsngr merged commit 9b85eee into wtsi-npg:devel Nov 27, 2023
2 checks passed
@mgcam mgcam deleted the update_changes_file branch January 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants